Repository navigation
refactor: remove unobserved audio preference notification - #2452
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the two
audioStoragePreferencesDidChangeposts and its unused notification-name declaration. Exhaustive tracked symbol and raw-string searches found no listeners. The Settings actions already persist the chosen value and invoke meeting maintenance or dictation pruning directly; those paths, confirmations, keys, raw values, defaults, and writes are unchanged.This extracts only SUPPORT-11 from broad pending #2336, leaving its unrelated retention-detail removal for a separate PR. #2336 remains unchanged. Independent full-diff and actual UI maintenance-call source review: GREEN before commit.
Validation at 497081f: 14 mapped checks PASS, including full concurrency typecheck. App build and unfiltered fast tests explicitly BLOCKED (exit 3) by reviewed invocation guards, so canonical deterministic proof stays FAIL; source receipt stable and clean. Standalone preflight passed; verifier speed check SKIPPED because Transcripted is running, and nothing was quit. No preference tests, audio retention operations, app/native runtime, or real user state was executed. This is source-backed removal of an internal unobserved notification, not a retention-policy change.